diff rgToolFactory.xml @ 25:8cc3f3c0e539 default tip

Now uses admin_users to check that the user is authorized to run this tool Docs adjusted.
author Ross Lazarus <ross.lazarus@gmail.com>
date Wed, 06 Jun 2012 14:16:25 +1000
parents 8289ebc513ab
children
line wrap: on
line diff
--- a/rgToolFactory.xml	Wed Jun 06 12:05:25 2012 +1000
+++ b/rgToolFactory.xml	Wed Jun 06 14:16:25 2012 +1000
@@ -1,7 +1,7 @@
 <tool id="rgTF" name="Tool Factory" version="0.05">
   <description>Makes scripts into tools</description>
   <command interpreter="python">
-#if ( $__user_email__ not in ['yourID@email','ross.lazarus@gmail.com'] ):
+#if ( $__user_email__ not in $__admin_users__ ):
      rgToolFactory.py --bad_user $__user_email__
   #else:
     rgToolFactory.py --script_path "$runme" --interpreter "$interpreter" 
@@ -111,6 +111,11 @@
 </configfile>
 </configfiles>
 <help>
+    
+.. class:: warningmark
+
+**Local Admins ONLY** Only users whose IDs found in the local admin_user configuration setting in universe_wsgi.ini can run this tool.
+
 **What it does** This tool enables a user to paste and submit an arbitrary R/python/perl script to Galaxy.
 
 **Input options** This version is limited to simple transformation or reporting requiring only a single input file selected from the history.
@@ -121,14 +126,13 @@
 **Tool Generation option** Once the script is working with test data, this tool will optionally generate a new Galaxy tool in a gzip file
 ready to upload to your local toolshed for sharing and installation.
 
-**Permission to to use this tool** must be explicitly granted by an administrator adding approved Galaxy user IDs to the local tool XML list of permitted users.  *It will not run otherwise*
-
 .. class:: warningmark
 
-**Note to system administrators** This tool offers *NO* built in protection against malicious scripts and should only be installed on private/personnal Galaxy instances.
-Under no circumstances should you allow any user to use this tool unless you really, really trust them with the power to do what they want as the Galaxy user.
+**Note to system administrators** This tool offers *NO* built in protection against malicious scripts. It should only be installed on private/personnal Galaxy instances.
+Admin_users will have the power to do anything they want as the Galaxy user if you install this tool.
 
 The tools generated by this tool will run just as securely as any other normal installed Galaxy tool but like any other new tools, should always be checked carefully before installation.
+We recommend that you follow the good code hygiene practices associated with safe toolshed.
 
 .. class:: warningmark